Skip to content

modify the contributing guide a tad bit to use uv run python -m reflex.utils.pyi_generator#5576

Merged
adhami3310 merged 1 commit into
mainfrom
modify-the-contributing-guide-a-tad-bit-to-use-uv-run-python--m-reflex.utils.pyi_generator
Jul 16, 2025
Merged

modify the contributing guide a tad bit to use uv run python -m reflex.utils.pyi_generator#5576
adhami3310 merged 1 commit into
mainfrom
modify-the-contributing-guide-a-tad-bit-to-use-uv-run-python--m-reflex.utils.pyi_generator

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR makes a targeted change to the CONTRIBUTING.md guide, modifying the command used to generate .pyi files from uv run python scripts/make_pyi.py to uv run python -m reflex.utils.pyi_generator. This change reflects an architectural improvement where the pyi generator has been properly modularized within the reflex.utils package.

The new approach using Python's module system (-m flag) is more robust as it:

  1. Ensures proper module resolution through Python's import system
  2. Is more resilient to different installation setups and environments
  3. Follows better Python packaging practices by treating the generator as a proper module

Confidence score: 5/5

  1. This is a safe documentation update that reflects an existing architectural improvement
  2. The change is straightforward, correct, and follows Python best practices for module organization
  3. No files need special attention as this is a simple documentation update reflecting an existing change

1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Comment thread CONTRIBUTING.md
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 15, 2025

CodSpeed Performance Report

Merging #5576 will not alter performance

Comparing modify-the-contributing-guide-a-tad-bit-to-use-uv-run-python--m-reflex.utils.pyi_generator (ca60512) with main (c5bfad4)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit 3607041 into main Jul 16, 2025
7 checks passed
@adhami3310 adhami3310 deleted the modify-the-contributing-guide-a-tad-bit-to-use-uv-run-python--m-reflex.utils.pyi_generator branch July 16, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants